D23075: Change default Dolphin toolbar layout

[Noah Davis]

ndavis added a comment.


  In D23075#512110 <https://phabricator.kde.org/D23075#512110>, @elvisangelaccio wrote:
  
  > Wow, this is quite a radical change :)
  >
  > I'm not against changing the default layout, but we should be 100% sure to get it right. It would be very annoying if we have to change it again in six months because people didn't like it.
  >
  > My comments after a quick try:
  >
  > 1. I don't think we should add the "Go Up" button because you can already achieve the same action by using the url navigator buttons.
  
  
  I kind of agree, but don't have a strong opinion since it's a common control in file managers and doesn't take up much space.
  
  > 2. Why the Split button on the right? It looks out of place imho.
  
  
  
  1. Because the controls on the left are "normal" controls that can be used whether you're using the regular file view or not. The controls on the right introduce other views like search and split view. Stash could go on the right side as well with that logic.
  2. Because we needed something on the right to give the GUI a bit more visual balance when the application menu is enabled.
  
  > 3. I wouldn't remove the Stash button because it shows up only if you have kio-stash installed. And it's a nice feature to advertise imho (it was the output of a GSoC project some years ago).
  
  Fair point. Might be off-topic, but I'm not sure what the usecase for stash is. I installed it as soon as it was available, but I don't know when I'd ever use it.
  
  > 4. This is possibly a problem in my setup, but this patch made my information panel disappear :O
  
  Looking at the diff, I see nothing in this patch that would do that. However, I am experiencing the same problem with the version of git master Dolphin that I compiled with `kdesrc-build`. I'm not sure what causes the problem, but the version of git master dolphin provided by openSUSE's KDE:Unstable repos still has the info panel.

REVISION DETAIL
  https://phabricator.kde.org/D23075

To: simonkr, #dolphin, #vdg, ngraham, GB_2, elvisangelaccio
Cc: filipf, meven, elvisangelaccio, felixernst, GB_2, ndavis, ngraham, kfm-devel, #vdg, #dolphin, aprcela, vmarinescu, fprice, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, crozbo, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190815/28a2dff7/attachment.htm>