D23087: Do not match daemonized dolphin instances: part 2
Elvis Angelaccio
noreply at phabricator.kde.org
Sun Aug 11 11:18:53 BST 2019
elvisangelaccio created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.
REVISION SUMMARY
`dolphin --daemon` does not have the `/dolphin/Dolphin_1` dbus path,
because it doesn't have any DolphinMainWindow.
Checking if the QDBusInterface is valid is not enough, we also need to look for dbus errors.
This should have been part of commit 7df5fc8edb54153f <https://phabricator.kde.org/R318:7df5fc8edb54153f877eed4690e77968a1b804ba>. Not sure how I missed it.
BUG: 408244
FIXED-IN: 19.08.0
TEST PLAN
1. Make sure the new "Open new folders in tabs" setting is enabled.
2. Run `dolphin --deamon` and make sure is the only dolphin process around.
3. Call the `org.freedesktop.FileManager1.ShowFolders` method from QDbusViewer.
REPOSITORY
R318 Dolphin
BRANCH
Applications/19.08
REVISION DETAIL
https://phabricator.kde.org/D23087
AFFECTED FILES
src/global.cpp
To: elvisangelaccio
Cc: kfm-devel, aprcela, vmarinescu, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190811/1016de35/attachment.htm>
More information about the kfm-devel
mailing list