D23075: Change default Dolphin toolbar layout

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  In D23075#510022 <https://phabricator.kde.org/D23075#510022>, @felixernst wrote:
  
  > There wasn't much discussion about using the view mode button in the VDG:
  >
  > > <thavn> perhaps we should consider which buttons have labels and which are just the icon as well...
  > >  <noahdvs> I find it odd that we use icons with no labels for the different views
  > >  <noahdvs> Maybe we should switch them for the View Mode toolbutton?
  >
  > I think the biggest reason for it is that the label makes it clear that these buttons change the view mode. Clicking it also shows the names of the three different view modes so users can decide by the names and not just by the icons. It also teaches the user the shortcuts for them.
  >  I think it looks better with the view mode button.
  >
  > In D23075#509940 <https://phabricator.kde.org/D23075#509940>, @ndavis wrote:
  >
  > > Make sure the default layout doesn't look lopsided when the application menu is enabled instead of the control button.
  >
  >
  > It does look kinda lopsided but I am not sure if it is worth it to change the default look because of that.
  
  
  It's fine how it is now, how it also was before. There are tooltips for the buttons, and if we really want to show a shortcut, we can do it in the tooltip, but then everywhere in a different patch.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23075

To: simonkr, #dolphin, #vdg, ngraham, GB_2
Cc: felixernst, GB_2, ndavis, ngraham, kfm-devel, #vdg, #dolphin, aprcela, vmarinescu, fprice, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, feverfew, trickyricky26, mglb, meven, crozbo, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190810/f292b67f/attachment.htm>