D20876: Remove Q_FOREACH, reserve space in destination list

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in filemetadataprovider.cpp:336
> It is probably not a big deal, but if the url is not a local file, this would over-allocate, wouldn't it?

Yes, but a) its a temporary, b) its an order of magnitude smaller than m_fileitems itself, c) not reserving typically overallocates as well (non-linear grows), and when resizing you need memory for the old and the new list.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20876

To: bruns, #baloo, #dolphin, nicolasfella, astippich, ngraham, elvisangelaccio
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190428/d5e4bb7e/attachment.htm>