D20876: Remove Q_FOREACH, reserve space in destination list

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> filemetadataprovider.cpp:336
>      QStringList urls;
> +    urls.reserve(m_fileItems.size());
>      // Only extract data from indexed files,

It is probably not a big deal, but if the url is not a local file, this would over-allocate, wouldn't it?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20876

To: bruns, #baloo, #dolphin, nicolasfella, astippich, ngraham, elvisangelaccio
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190428/d6391cca/attachment.htm>