D19770: Use placeholder for search action

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  I still think that the rename from "Search" to "Find" should be done either upstream/globally or not at all.
  
  Anyway, it's unrelated from this commit, which is just about moving to placeholders everywhere (which I agree with).

INLINE COMMENTS

> dolphinmainwindow.cpp:931-933
> +    // Overwrite Find action to Search action
> +    QAction *search = ac->action(KStandardAction::name(KStandardAction::Find));
> +    search->setText(i18n("Search..."));

We shouldn't rename a standard action. From System Settings -> Global Shortcuts it will still be named "Find..."

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19770

To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190420/75c63054/attachment.htm>