D20240: [RFC] Improve Home button function when renaming files

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kitemlistroleeditor.cpp:121
> +        } else  {
> +            //if already at StartOfLine, move 1 line up
> +            if (event->modifiers() & Qt::ShiftModifier) {

This doesn't seem to implement what's been asked for in the bug report. The request was for the Home key to always go to the beginning of the filename, not the beginning of the line and then up one line if you hit it again. That's not a behavior I'm aware of being used anywhere else, so it would be unfamiliar and strange to users.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20240

To: msciubidlo, #dolphin, ngraham
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190405/7de81422/attachment.htm>