D15989: Do not offer to unmount / or /home

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitemmodel.cpp:215
>                                    device.as<Solid::StorageAccess>()->isAccessible();
> -    if (!providesTearDown) {
> +    if (!providesTearDown || item->url() == QUrl("file:/") || item->url() == QUrl("file:/home")) {
>          return nullptr;

Please use `QUrl::fromLocalFile(QDir::rootPath())` and `QUrl::fromLocalFile("/home")` instead.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15989

To: thsurrel, #dolphin, #vdg, elvisangelaccio
Cc: elvisangelaccio, ngraham, broulik, bruns, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181007/ff7b7ab1/attachment.htm>