D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter updated this revision to Diff 45938.
sitter marked 4 inline comments as done.
sitter added a comment.


  - check kdnssd version; do not use dnssd discovery if it too old and suffers from signal racing (also see D16298 <https://phabricator.kde.org/D16298>)
  - fix typo in function name
  - no longer use debug names for udsentry
  - convert resolution from fixme to todo, I am unsure if we should even care though. input welcome
  - add note about lack of workgroup resolution, it's also unclear if workgroup resolution in its current form has any future. specifically LLMNR (the future replacement of NBS) does not have a concept of SMB workgroups, so the way I see it workgroup discovery is a dead-end anyway. in the future the only way to inspect workgroups would be to actually talk to the SMB host (which may require auth) and as such is impossible to do consistently AFAICT

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16299?vs=43869&id=45938

BRANCH
  smb-discovery

REVISION DETAIL
  https://phabricator.kde.org/D16299

AFFECTED FILES
  CMakeLists.txt
  config-runtime.h.cmake
  smb/CMakeLists.txt
  smb/kio_smb.h
  smb/kio_smb_browse.cpp

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181121/f8cd7a35/attachment.htm>