D12218: Remove Reload button from the file dialogs' toolbar

[Mark Gaiser]

markg added a comment.


  In D12218#271375 <https://phabricator.kde.org/D12218#271375>, @rkflx wrote:
  
  > In D12218#271290 <https://phabricator.kde.org/D12218#271290>, @davidedmundson wrote:
  >
  > > > It can be useful for network views, but those are a minority of use cases
  > >
  > > Every large scale KDE deployment (from my POV by far our most important userbase) has a network share.
  > >
  > > It might not be needed often, but when it's needed it's needed.
  >
  >
  > Would you be okay with some of the compromises mentioned above, or is this again an all-or-nothing thing?
  >
  > - Show toolbar button only for network folders.
  > - Move Reload to `KUrlNavigator`.
  
  
  The problem would then be the detection of a network share.
  I can mount a cifs share locally, you'd not know the difference.
  Same with any filesystem. They can all become local. And - frankly - with SMB it has some performance benefits to mount it locally with cifs.
  
  You could go for the "isSlow" check (smb is included in there iirc), but it would be a quite weak check.
  I'd just say no to this. Reload needs to stay imho.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, abetts, markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180531/49630b88/attachment.htm>