D12795: Re-allow running Dolphin as the root user (but still not using sudo)

Mark Gaiser noreply at phabricator.kde.org
Sun May 20 14:43:33 BST 2018


markg added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in main.cpp:48
> Please use  `!qEnvironmentVariableIsEmpty()`. Same below.

Why did Qt even add such a non-qt name?
qgetenv("SUDO_USER").isEmpty()

is more Qt-ish. The qgetenv gives a QByteArray and the isEmpty is just a check on the bytearray and verbose enough imho.

I'm fine with any of the options though.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12795

To: ngraham, markg, elvisangelaccio, #dolphin
Cc: elvisangelaccio, mmustac, Fuchs, markg, graesslin, nicolasfella, zzag, kfm-devel, emmanuelp, spoorun, navarromorales, isidorov, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180520/4abaaaa9/attachment.htm>


More information about the kfm-devel mailing list