D12795: Re-allow running Dolphin as the root user (but still not using sudo)

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:48
>      if (getuid() == 0) {
> -        std::cout << "Executing Dolphin as root is not possible." << std::endl;
> -        return EXIT_FAILURE;
> +        if (getenv("SUDO_USER")) {
> +            std::cout << "Executing Dolphin with sudo is not possible due to unfixable security vulnerabilities." << std::endl;

Please use  `!qEnvironmentVariableIsEmpty()`. Same below.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12795

To: ngraham, markg, elvisangelaccio, #dolphin
Cc: elvisangelaccio, mmustac, Fuchs, markg, graesslin, nicolasfella, zzag, kfm-devel, emmanuelp, spoorun, navarromorales, isidorov, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180520/c38dcdd4/attachment.htm>