D12807: Akregator feed detector plugin: Port the context menu plugin

[David Faure]

dfaure accepted this revision as: dfaure.
dfaure added a comment.


  Still strange that "rss" or "rdf" anywhere in the path is enough, but I'm no rss expert... Looks good overall.

INLINE COMMENTS

> akregatorplugin.cpp:72
> +        if (isFeedUrl(item))
> +        {
> +            qCDebug(AKREGATORPLUGIN_LOG) << "found feed" << item.url();

BTW why the '{' on separate lines? The Qt5/KF5 coding style is to have it on the same line, and you left it that way further down in this file, which is now inconsistent with itself.

> marten wrote in akregatorplugin.h:46
> Made file-static, but left the next function as member to avoid having to construct m_feedMimeTypes every time (or complicate with global static).

Sure, the other function should stay.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D12807

To: marten, #konqueror, #plasma, dfaure
Cc: dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180511/a70bdf70/attachment.htm>