D12731: Disable all the 'create new' items when in the Trash

Nathaniel Graham noreply at phabricator.kde.org
Sun May 6 21:11:05 BST 2018


ngraham created this revision.
ngraham added reviewers: Dolphin, broulik.
ngraham requested review of this revision.

REVISION SUMMARY
  Disable all the items in the 'create new' menu when the active view is in the trash,
  because they're not useful. We don't disable the entire menu because it's useful to
  be able to see what specific things are disabled.
  
  BUG: 332464
  FIXED-IN: 18.08.0

TEST PLAN
  - Enter the trash with and without a split view; the 'create new' menu items are all disabled
  - Be looking at something other than the trash with and without a split view; the 'create new' menu items are all enabled
  - Toggle between split views (one in the trash, one elsewhere); menu is correct for both cases
  
  Out of the trash:
  
  In the trash:

REPOSITORY
  R318 Dolphin

BRANCH
  disable-create-new-menu-in-trash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12731

AFFECTED FILES
  src/dolphinmainwindow.cpp

To: ngraham, #dolphin, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180506/9a178735/attachment.htm>


More information about the kfm-devel mailing list