D11816: Split Image Size into Width/Height

Julian Schraner noreply at phabricator.kde.org
Sat Mar 31 20:42:36 BST 2018


xyquadrat added inline comments.

INLINE COMMENTS

> ngraham wrote in kfileitemmodel.cpp:1850
> Maybe make it explicit that we're falling through for these with`Q_FALLTHROUGH()`

TBH, I never heard of `Q_FALLTHROUGH()` before, so I had to look it up & found this: https://wiki.qt.io/Qt_Coding_Style#Switch_statements

Qt advises to not use this if another case follows immediately, but I can obviously still do this if this way is preferred here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11816

To: xyquadrat, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180331/c04e74ab/attachment.htm>


More information about the kfm-devel mailing list