D11816: Split Image Size into Width/Height

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.


  +1 conceptually; it was never clear to the user how you could sort by both width and height at the same time. Code looks sane now (just one comment), and it works fine in my testing; actually sorting by width or height both seem to work as expected.

INLINE COMMENTS

> kfileitemmodel.cpp:1850
> +    case RatingRole:
> +    case WidthRole:
> +    case HeightRole: {

Maybe make it explicit that we're falling through for these with`Q_FALLTHROUGH()`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11816

To: xyquadrat, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180331/1aeb5c58/attachment.htm>