D11650: Fix alignment of icons in Places panel and Compact view mode

[Vlad Zagorodniy]

zzag added a comment.


  In D11650#235489 <https://phabricator.kde.org/D11650#235489>, @sharvey wrote:
  
  > F5769823: Screenshot_20180327_131225.png <https://phabricator.kde.org/F5769823>
  >
  > F5769827: Screenshot_20180327_131249.png <https://phabricator.kde.org/F5769827>
  >  If we look at the file listing instead of the Places list for more examples, we can see that there seems to be a size discrepancy between the lineart icons and the fully-rendered icons. In addition, a potential inconsistency (?) between capital letters and lowercase letters. Or maybe it's just a trick of perception. Or maybe there's a reason I don't like Noto Sans. ;)
  
  
  It's because action icons have inner padding.
  
  ---
  
  F5769987: noto.png <https://phabricator.kde.org/F5769987>
  
  As you see, Noto Sans' midline is slightly lower than text rect's midline so that's why text feels bottom-aligned, I guess. It doesn't have anything to do with rounding errors, etc.

REPOSITORY
  R318 Dolphin

BRANCH
  align-compact-icons

REVISION DETAIL
  https://phabricator.kde.org/D11650

To: sharvey, #dolphin, ngraham, cfeck
Cc: zzag, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180327/ee48fd6f/attachment.htm>