D11650: Fix alignment of icons in Places panel and Compact view mode

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Please also update the commit message explaining why we are dividing by 2.0

INLINE COMMENTS

> kstandarditemlistwidget.cpp:1018
>          // Center horizontally and align on bottom within the icon-area
> -        m_pixmapPos.setX((widgetSize.width() - m_scaledPixmapSize.width()) / 2);
> +        m_pixmapPos.setX((widgetSize.width() - m_scaledPixmapSize.width()) / 2.0 );
>          m_pixmapPos.setY(padding + scaledIconSize - m_scaledPixmapSize.height());

Nitpick: please remove space before the last `)`

> kstandarditemlistwidget.cpp:1024
> +        m_pixmapPos.setX(textInfo->pos.x() - 2.0 * padding
> +                      - (scaledIconSize + m_scaledPixmapSize.width()) / 2.0 );
> +

Same here

REPOSITORY
  R318 Dolphin

BRANCH
  align-compact-icons

REVISION DETAIL
  https://phabricator.kde.org/D11650

To: sharvey, #dolphin, ngraham, cfeck
Cc: zzag, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180327/7d26096a/attachment.htm>