D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming

[Nathaniel Graham]

ngraham added a subscriber: hein.
ngraham added a comment.


  In D10698#228277 <https://phabricator.kde.org/D10698#228277>, @emateli wrote:
  
  > Apologies in advance for the wall of text.
  >
  > > - The table view needs better headers. Instead of "1" and "2", how about something more like "Current names" and "New names"
  >
  > It's "Name" and "New Name".
  
  
  Hmm, I still see "1" and "2". Did you push a new version of the patch up to Phabricator with `arc diff`?
  
  > I personally prefer a more traditional status bar for such information and rather dislike the KMessageWidget which I have 2 issues against:
  > 
  > 1. When it appears it causes a layout scroll since it will now occupy space in the window.
  
  That's true, but can be made a smaller issue by locating it right above the buttons. That way only the buttons will move, and the main UI will remain the same.
  
  > 2. It's not very pretty.
  
  It's currently being redesigned, so hopefully that will be addressed. Regardless, consistency is important, as if we consistently use an ugly thing, we can redesign to to be prettier and everyone benefits. :) I believe @hein is even working on a pop-over version that will address your very legitimate concern about forcing a layout change.
  
  >> - Instead of making users click on a Preview button, is there any chance we can preview in real time as you type?
  > 
  > Done. Removed the preview button entirely, once user stops typing or changes one of the settings the preview will be automatically generated.
  
  Did you push a new version of the patch to Phabricator? I don't see the changes. You might need to do another `arc diff` to update the revision here.
  
  >> - What's the difference between `#name` and `#bname`? Along with `#ext` these terms seem excessively jargonistic.
  > 
  > 
  > 
  > - `#name` is the full name with extension
  > - `#bname` is the base name
  > - `#ext` is the extension.
  > 
  >   Looking forward on input on how to simplify these. A more verbose, but human-readable templating could be with some sort of indicator, such as `@FileName`, `@BaseName`, `@Extension`. For the date variables I kept the same formatting as Spectacle for consistency but they too could be renamed to things like `@Year` and so on. Anyhow, this won't fit on a label and needs either a dialog or a link to some manual page to clarify things. Especially given the complexity of the next two modes.
  
  Might be worth taking a look at how Spectacle handles usability for tokens like these:
  
  F5760108: Spectacle explanation.png <https://phabricator.kde.org/F5760108>
  
  >> Also, since the Find & Replace tab already does regex matching, could we find a way to collapse New name from matches into that tab?
  > 
  > I'd rather not. That page might become cluttered and the only thing they share is the use of RegEx. Besides, one is Find & Replace while the other doesn't really do any replacing at all.
  
  Looking at F5749965: Screenshot_20180311_220027.png <https://phabricator.kde.org/F5749965>
  
  ...I think an average user would consider this a variant of find and replace. That said, an average user would be rather perplexed by this, so maybe we should hide it better in the first place. It //is// super-advanced functionality, after all.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10698

To: emateli, dfaure, elvisangelaccio, ngraham, #dolphin
Cc: hein, rkflx, anthonyfieroni, mmustac, nicolasfella, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180320/a9fac4fc/attachment.htm>