D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  Apologies in advance for the wall of text.
  
  > - The table view needs better headers. Instead of "1" and "2", how about something more like "Current names" and "New names"
  
  It's "Name" and "New Name".
  
  > - I don't like that the bottom buttons aren't aligned to the bottom of the window. I understand that it's to make room for some text under them, but maybe we can find a better way to display that. KMessageWidgets are often a good fit for this kind of inline semi-transient notification.
  
  I personally prefer a more traditional status bar for such information and rather dislike the KMessageWidget which I have 2 issues against:
  
  1. When it appearts it causes a layout scroll since it will now occupy space in the window.
  2. It's not very pretty.
  
  However I have no strong opinion on the matter and best would be to follow the convention.
  
  > - Instead of making users click on a Preview button, is there any chance we can preview in real time as you type?
  
  Done. Removed the preview button entirely, once user stops typing or changes one of the settings the preview will be automatically generated.
  
  > - What's the difference between `#name` and `#bname`? Along with `#ext` these terms seem excessively jargonistic.
  
  
  
  - `#name` is the full name with extension
  - `#bname` is the base name
  - `#ext` is the extension.
  
  Looking forward on input on how to simplify these. A more verbose, but human-readable templating could be with some sort of indicator, such as `@FileName`, `@BaseName`, `@Extension`. For the date variables I kept the same formatting as Spectacle for consistency but they too could be renamed to things like `@Year` and so on. Anyhow, this won't fit on a label and needs either a dialog or a link to some manual page to clarify things. Especially given the complexity of the next two modes.
  
  > - I couldn't figure out what New name from matches actually did without reading the description you write in this revision. Since it requires the use of regular expressions, I think that detail needs to be mentioned somewhere (and maybe hidden a bit better, since that makes it a //very// advanced feature).`
  
  Like mentioned, this whole thing needs some documentation page or a help dialog. It's also now called "Captured Groups" but still looking forward to suggestions on how to better label this.
  
  > Also, since the Find & Replace tab already does regex matching, could we find a way to collapse New name from matches into that tab?
  
  I'd rather not. That page might become cluttered and the only thing they share is the use of RegEx. Besides, one is Find & Replace while the other doesn't really do any replacing at all.
  
  ---
  
  Issues that have arisen from this:
  
  **Batch renaming done in KIO.**
  
  The Batch rename command in KIO takes it upon itself to do the expansion for the `#` placeholder. To make matters worse even if `#` is not present it will append the number at the end regardless.
  
  What I propose KIO gets is simply a batch rename operation that accepts two lists, the current names, the new names and should simply do the rename in a batch without any additional processing on the file names. A simple rename "these" files into "those".
  
  **Localization.**
  
  I set the locale to german in the system preferences and tried to reuse some of the existing translations for this, however even though they are translated in german([https://websvn.kde.org/*checkout*/branches/stable/l10n-kf5/de/messages/applications/dolphin.po](I consulted this file)) they won't apply. Probably not big of an issue but I'd rather see how they look and that they are in fact, translated.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10698

To: emateli, dfaure, elvisangelaccio, ngraham, #dolphin
Cc: rkflx, anthonyfieroni, mmustac, nicolasfella, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180317/556987c0/attachment.htm>