D11481: [KItemListView] Check if KItemListStyleOption actually changed before emitting a change

Mark Gaiser noreply at phabricator.kde.org
Mon Mar 19 13:04:41 GMT 2018


markg added a comment.


  I wonder if the fix is really fixing an issue here or just masking it?
  You're not setting the style if it's already set. That indicates something somewhere tries to set it when it was already set and that something should not do that.
  
  Also, the commit message is a bit odd. It talks about a timer yet the change does not touch any timers. It merely prevents a style change when the style is already changed.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11481

To: broulik, #dolphin, elvisangelaccio
Cc: markg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180319/f6a79316/attachment.htm>


More information about the kfm-devel mailing list