D11481: [KItemListView] Check if KItemListStyleOption actually changed before emitting a change
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Mar 19 12:24:18 GMT 2018
broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio.
broulik requested review of this revision.
REVISION SUMMARY
The preview generator waits for everything to have settled a bit and starts a timer of 200ms before generating a preview. This timer was fired everytime when entering a folder needlessly delaying preview generation since it never checked whether the style option actually changed.
TEST PLAN
- Previews generate noticeably faster when moving between folders with the same icon size and settings.
- Switching between view modes still works
- Navigating between folders of varying view modes still triggers the old delay
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D11481
AFFECTED FILES
src/kitemviews/kitemliststyleoption.cpp
src/kitemviews/kitemliststyleoption.h
src/kitemviews/kitemlistview.cpp
To: broulik, #dolphin, elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180319/7e9c9b7c/attachment.htm>
More information about the kfm-devel
mailing list