D11118: Show a message if Konsole part is not installed

Henrik Fehlauer noreply at phabricator.kde.org
Thu Mar 8 20:25:42 GMT 2018


rkflx added a comment.


  In D11118#221530 <https://phabricator.kde.org/D11118#221530>, @rominf wrote:
  
  > - Hide Install Konsole button if OS doesn't handle appstream

INLINE COMMENTS

> terminalpanel.cpp:151
> +            if (!doesOsHandleAppstream) {
> +                konsoleNotInstalledText += i18n(" Try installing package 'konsole' with package manager.");
> +            }

The space before "Try" is a bit odd, I'd guess translators might just omit it.

Why not simply add a newline between both messages? Would help for languages with longer translations too…

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11118

To: rominf, #dolphin, ngraham
Cc: rkflx, ngraham, elvisangelaccio, broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180308/146b5de2/attachment.htm>


More information about the kfm-devel mailing list