D11118: Show a message if Konsole part is not installed

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Very nice. One textual nitpick below.
  
  Also, not Dolphin crashes in `openUrl()` when I click the "Install Konsole" button when Discover is installed. Here's the backtrace:
  
    Thread 1 "dolphin" received signal SIGSEGV, Segmentation fault.
    0x00007ffff17bcb10 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    (gdb) bt
    #0  0x00007ffff17bcb10 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #1  0x00007ffff2435826 in QDesktopServices::openUrl(QUrl const&) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
    #2  0x00007ffff7b4893b in TerminalPanel::showEvent(QShowEvent*)::{lambda()#2}::operator()() const
        () from /usr/lib/x86_64-linux-gnu/libkdeinit5_dolphin.so
    #3  0x00007ffff7b4984f in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, TerminalPanel::showEvent(QShowEvent*)::{lambda()#2}>::call({lambda()#2}&, void**) ()
       from /usr/lib/x86_64-linux-gnu/libkdeinit5_dolphin.so
    #4  0x00007ffff7b49821 in void QtPrivate::Functor<TerminalPanel::showEvent(QShowEvent*)::{lambda()#2}, 0>::call<QtPrivate::List<>, void>({lambda()#2}&, void*, {lambda()#2}&*) ()
       from /usr/lib/x86_64-linux-gnu/libkdeinit5_dolphin.so
    #5  0x00007ffff7b497ef in QtPrivate::QFunctorSlotObject<TerminalPanel::showEvent(QShowEvent*)::{lambda()#2}, 0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) () from /usr/lib/x86_64-linux-gnu/libkdeinit5_dolphin.so
    #6  0x00007ffff19787b6 in QMetaObject::activate(QObject*, int, int, void**) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #7  0x00007ffff29114a2 in QAction::triggered(bool) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #8  0x00007ffff2913c10 in QAction::activate(QAction::ActionEvent) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #9  0x00007ffff2a10900 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #10 0x00007ffff2a10a3d in QAbstractButton::mouseReleaseEvent(QMouseEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #11 0x00007ffff2aed0da in QToolButton::mouseReleaseEvent(QMouseEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #12 0x00007ffff2956f88 in QWidget::event(QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #13 0x00007ffff2aed1b9 in QToolButton::event(QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #14 0x00007ffff2917acc in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #15 0x00007ffff292003b in QApplication::notify(QObject*, QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #16 0x00007ffff194b3c8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #17 0x00007ffff291e9df in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #18 0x00007ffff2970f4d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #19 0x00007ffff297397b in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #20 0x00007ffff2917acc in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #21 0x00007ffff291f417 in QApplication::notify(QObject*, QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #22 0x00007ffff194b3c8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #23 0x00007ffff216fef0 in QGuiApplicationPrivate::processMouseEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
    #24 0x00007ffff2171e45 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
    #25 0x00007ffff214b8fb in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
    #26 0x00007fffe29671ab in ?? () from /usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
    #27 0x00007ffff194964a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
       from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #28 0x00007ffff1952854 in QCoreApplication::exec() ()
       from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #29 0x00007ffff7af3c9d in kdemain () from /usr/lib/x86_64-linux-gnu/libkdeinit5_dolphin.so
    #30 0x00000000004007d8 in main ()

INLINE COMMENTS

> terminalpanel.cpp:151
> +            if (!doesOsHandleAppstream) {
> +                konsoleNotInstalledText += i18n(" Try installing package 'konsole' with package manager.");
> +            }

"Try installing the 'konsole' package with your package manager"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11118

To: rominf, #dolphin, ngraham
Cc: rkflx, ngraham, elvisangelaccio, broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180308/98a11fe8/attachment.htm>