D11118: Show a message if Konsole part is not installed

[Nathaniel Graham]

ngraham added a comment.


  What I don't like is how the KMessageWidget is right in the middle of the panel, really. I'd accept the current UI if we display it at the top of the panel, rather than in the middle.
  
  The "no appstream:// Url handler installed" message from KIO is accurate, but kind of unpleasant right now, and it doesn't give the user a clear path forward. It would be nice if  we provided our own message that offered rudimentary instructions to help the user install the necessary packages using the command line, like your original patch did. This is that right place for that!
  
  And what do you think about the idea of starting a watcher for the presence of Konsole if the URL open task returns 0, and once it's installed, automatically re-opening the panel? That way, the moment Konsole is installed, the panel can instantly work! That would be a truly fantastic UI, and people will fall in love with it.
  
  > Let's ship it!
  
  When it's done, we certainly will! :-) The purpose of this review process is not to be an annoying gate, but to make sure that code that gets committed is of the highest quality and doesn't require follow-up commits to fix bugs or improve the UI. People get busy or lose interest and those follow-up -patches often don't materialize. It's important to get it right in the first go as often as we can.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11118

To: rominf, #dolphin
Cc: ngraham, elvisangelaccio, broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180308/60f0bfcd/attachment.htm>