D11118: Show a message if Konsole part is not installed

Roman Inflianskas noreply at phabricator.kde.org
Wed Mar 7 14:13:22 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> broulik wrote in terminalpanel.cpp:143
> Doesn't installing "Konsole" imply Konsole part being there? So I would simplify it to "Terminal cannot be shown because Konsole is not installed." - bonus points for using AppStream to open Discover to install it ;)

The user may want to use Konsole only as a part of Dolphin.

> progwolff wrote in terminalpanel.cpp:140
> Package is called "konsole" on Arch Linux. I would leave out this part.

I don't like guessing, but it's better to provide the user hints on what she should install. I'm suggesting listing all variants. After all, this text shouldn't be beautiful, as the user will read it only once. He either installs the required package and the text will gone, or not, but then he won't open terminal panel anymore.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11118

To: rominf, #dolphin
Cc: broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180307/8a01407f/attachment.htm>


More information about the kfm-devel mailing list