D11118: Show a message if Konsole part is not installed

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Mar 7 14:10:56 GMT 2018


broulik added inline comments.

INLINE COMMENTS

> terminalpanel.cpp:143
> +            m_konsolePartMissingLabel = new QLabel(i18n(
> +                    "Terminal cannot be shown because Konsole part (package \"konsole-part\" or \"konsole-kpart\") is not installed."));
> +            m_konsolePartMissingLabel->setAlignment(Qt::AlignCenter);

Doesn't installing "Konsole" imply Konsole part being there? So I would simplify it to "Terminal cannot be shown because Konsole is not installed." - bonus points for using AppStream to open Discover to install it ;)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11118

To: rominf, #dolphin
Cc: broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180307/5f968f36/attachment.htm>


More information about the kfm-devel mailing list