D10990: Add "Open symlink destination folder" into symlink's context menu

[Nathaniel Graham]

ngraham added a comment.


  In D10990#220203 <https://phabricator.kde.org/D10990#220203>, @rominf wrote:
  
  > In D10990#220200 <https://phabricator.kde.org/D10990#220200>, @ngraham wrote:
  >
  > > So what do you think about adding Show Original into the File menu when a shortcut is selected?
  >
  >
  > I'm positive about this. But I think this should be done after unifying file menu and context menu (`Compress`, `Actions`, etc. is not shown in the file menu).
  
  
  Why not do it now? We're already touching this code, might as well do the right thing here to set a good example. If we don't, we're just making that problem worse and giving ourselves more work later, no?
  
  >> Also, I notice that the behavior is still different for files and folders: original files are highlighted in their parent directories, while original folders are opened. Little inconsistencies like this tend to drive OCD people mad. :)
  > 
  > That's strange behavior, but in my opinion, it's OK for a such an infrequent feature as show original.
  
  If it's strange behavior, we should fix it. :) Using `KIO:highlightInFileManager()` would resolve the situation, as this is exactly what it was designed for. Opening a new window isn't the end of the world, and probably beneficial anyway for normal users who might otherwise get confused when the current view abruptly changes to a different one.
  
  And if we also fix https://bugs.kde.org/show_bug.cgi?id=183429, then the problem basically goes away entirely. It's generally better to fix underlying issues if we can, rather than working around them.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10990

To: rominf, #dolphin, ngraham
Cc: ngraham, elvisangelaccio, markg, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180306/f2408997/attachment.htm>