D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Mark Gaiser]

markg resigned from this revision.
markg added inline comments.

INLINE COMMENTS

> rominf wrote in dolphinmainwindow.cpp:452-466
> That's 2 different switches. Look at `case QDialogButtonBox::No:` branch. I'm sure it's possible to merge them, but that would hurt readability.

Right, but this also hurts ;)
Oke, it's a tradeoff i suppose. Readability over duplication. Readability (in this case) wins imho so feel free to ignore my comment on this.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/8d521b88/attachment.htm>