D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:438
> +
> +        const int result = KMessageBox::createKMessageBox(
> +                dialog,

Please use `const auto result`, since this function returns a `QDialogButtonBox::StandardButton`.

> dolphinmainwindow.cpp:457-460
> +                if (!m_terminalPanel->isVisible())
> +                    actionCollection()->action("show_terminal_panel")->trigger();
> +                else
> +                    m_terminalPanel->setFocus();

Missing braces

> terminalpanel.cpp:62
>  
> -QString TerminalPanel::currentWorkingDirectory()
> +QString TerminalPanel::currentWorkingDirectory() const
>  {

Unrelated change, should go in its own commit.

> terminalpanel.cpp:108
> +        return m_terminal->foregroundProcessName();
> +    } else {
> +        return QString();

`else` is not really need after a `return`.

> terminalpanel.h:101
>      QQueue<QString> m_sendCdToTerminalHistory;
> +
>  };

Unrelated whitespace change

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, markg, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/5f50eb85/attachment.htm>