D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

Roman Inflianskas noreply at phabricator.kde.org
Sat Mar 3 11:30:52 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:390
>          KGuiItem::assign(buttons->button(QDialogButtonBox::Cancel), KStandardGuiItem::cancel());
>          buttons->button(QDialogButtonBox::Yes)->setDefault(true);
>  

@ngraham
How about this? Closing a window with all opened tabs is destructive in my opinion. My vote is for `Cancel`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, markg
Cc: markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/215f9965/attachment.htm>


More information about the kfm-devel mailing list