D10986: Modernize the syntax of shortcuts

Mark Gaiser noreply at phabricator.kde.org
Sat Mar 3 12:18:31 GMT 2018


markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Ha, funny. I didn't even know there was an old syntax for this. I've always used the + syntax.
  I ran it and it seems to be working just fine (just tested a few shortcuts, not all).

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:1052
> I'd actually prefer to get rid of harcoded shortcuts where possible. For example here we should use whatever default shortcut the user set in systemsettings for the New action, rather than manually hardcoding CTRL+N.

I agree, but this commit seems focused on refactoring to this + format style. Lets keep the global system defined shortcuts for another commit.

REPOSITORY
  R318 Dolphin

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D10986

To: rominf, #dolphin, markg
Cc: markg, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/c09cb217/attachment.htm>


More information about the kfm-devel mailing list