D10986: Modernize the syntax of shortcuts

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1052
>      newWindow->setText(i18nc("@action:inmenu File", "New &Window"));
> -    actionCollection()->setDefaultShortcut(newWindow, Qt::CTRL | Qt::Key_N);
> +    actionCollection()->setDefaultShortcut(newWindow, Qt::CTRL + Qt::Key_N);
>      connect(newWindow, &QAction::triggered, this, &DolphinMainWindow::openNewMainWindow);

I'd actually prefer to get rid of harcoded shortcuts where possible. For example here we should use whatever default shortcut the user set in systemsettings for the New action, rather than manually hardcoding CTRL+N.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10986

To: rominf, #dolphin
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180303/9ea858cd/attachment.htm>