D10804: Show "Empty Trash" button inside trash directory

[Roman Inflianskas]

rominf marked 3 inline comments as done.
rominf added inline comments.

INLINE COMMENTS

> markg wrote in dolphintrash.cpp:64-66
> I rather not do that. Quick fixes (nearly) always stay in for far too long or people just forget about it altogether because it "seemingly works".
> Lets do it this way, I will have a look at KDirLister to see if i can get this fixed. I'd have to write a valid testcase first that fails which makes finding the bug itself easier. Writing that test is the difficult part i think.
> 
> If i haven't found a fix for it by the end of sunday then i'm not going to find one anytime soon.
> 
> So: wait till sunday. If i found a fix, use it.
> If i found no fix then by all means, use this workaround but put comments around it that it is a workaround and should be fixed in KIO instead.

OK. I agree.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/08458b8f/attachment.htm>