D10804: Show "Empty Trash" button inside trash directory

[Mark Gaiser]

markg added a comment.


  In D10804#216635 <https://phabricator.kde.org/D10804#216635>, @rominf wrote:
  
  > In D10804#216484 <https://phabricator.kde.org/D10804#216484>, @markg wrote:
  >
  > > Is the singleton class really needed? It imho seems a bit overkill for merely the trash status.
  > >  On the other hand, it does neatly move some trash functionality in it's own little space. But a class?..
  > >  The functions are also all self contained so it might be better suited in it's own namespace (say a TrashHelper::<youFunctions>).
  >
  >
  > Yep, a singleton is needed, though I don't like it too. I have a signal to emit. That means I have to have `QObject`. Nobody can emit signals from static functions, hence I need a singleton.
  
  
  Ah, right. You have a signal in there. Oke, a class is fine.

INLINE COMMENTS

> rominf wrote in dolphintrash.cpp:64-66
> I understand that this is a bug. I've tried to fix it but I didn't understand how does `KDirLister` work.
> I propose to accept this quick fix for now. Meanwhile, fill a bug report in KIO. Moreover, it would be faster.

I rather not do that. Quick fixes (nearly) always stay in for far too long or people just forget about it altogether because it "seemingly works".
Lets do it this way, I will have a look at KDirLister to see if i can get this fixed. I'd have to write a valid testcase first that fails which makes finding the bug itself easier. Writing that test is the difficult part i think.

If i haven't found a fix for it by the end of sunday then i'm not going to find one anytime soon.

So: wait till sunday. If i found a fix, use it.
If i found no fix then by all means, use this workaround but put comments around it that it is a workaround and should be fixed in KIO instead.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/7d17d8f6/attachment.htm>