D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

Roman Inflianskas noreply at phabricator.kde.org
Fri Mar 2 08:38:49 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> broulik wrote in dolphinmainwindow.cpp:425
> Can't you use any of `KMessageBox`'s built-in dialogs rather than creating the entire `QDialog` yourself?

I just copy pasted `ConfirmClosingMultipleTabs` code because that's my first written dialog in KDE and I don't know how the things are done.

If you think that this should be changed, then we have to change `ConfirmClosingMultipleTabs` too.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin
Cc: broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180302/78f23755/attachment.htm>


More information about the kfm-devel mailing list