D10804: Show "Empty Trash" button inside trash directory

[Mark Gaiser]

markg added inline comments.

INLINE COMMENTS

> rkflx wrote in dolphintrash.cpp:48-49
> @markg https://lxr.kde.org/source/frameworks/kio/src/core/kfileitem.cpp#0883:
> 
>   // We need to find if the trash is empty, preferably without using a KIO job.
>   // So instead kio_trash leaves an entry in its config file for us.
> 
> Cannot comment on whether that's only applicable for KIO or Dolphin too.

Ahh, that makes sense.
If dolphin only needed the icon it wouldn't need to look at that file, but it also needs to know the state (empty or full) so it looks at the file.

Thank you for the pointer! No wonder i couldn't find it in Dolphin, it wasn't there ;)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180301/fc1604aa/attachment.htm>