D10804: Show "Empty Trash" button inside trash directory

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> markg wrote in dolphintrash.cpp:48-49
> I see this was there before (in a different location), but i just don't get this part. "trashrc" is only used here (I've searched through the code) and it looks like nothing sets it hence the default is used which is true which in turn indicates the trash is empty.
> 
> Why?
> This just doesn't make sense to me.
> 
> Or.. i can't search and it is used elsewhere, but then i didn't find it.

@markg https://lxr.kde.org/source/frameworks/kio/src/core/kfileitem.cpp#0883:

  // We need to find if the trash is empty, preferably without using a KIO job.
  // So instead kio_trash leaves an entry in its config file for us.

Cannot comment on whether that's only applicable for KIO or Dolphin too.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180301/6eee30c4/attachment.htm>