D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

Nathaniel Graham noreply at phabricator.kde.org
Fri Jun 29 23:59:49 BST 2018


ngraham created this revision.
ngraham added reviewers: broulik, Dolphin, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 379129
  FIXED-IN 5.48
  
  `KRecentDocuments` currently checks for duplicate entries, but its criteria are very restrictive: not only does the path need to match, but also the app that the path was opened with. As a result, if you open a file with two different apps (say, Kate and KWrite), you get two entries. From a regular user perspective, these are duplicates--especially since the entries are not visibly badged in any way with what app they will open with, so they look identical. Even if they were, it's not really a useful feature; when you want to access a recently-used document, it's highly likely that you just want to use the default app to open it.
  
  This patch removed the app-matching criteria and considers an entry a duplicate only if its path matches that of an existing entry.

TEST PLAN
  Open the same document with both Kate and KWrite. Only one copt of the document shows up in recentdocuments:/ in Dolphin.

REPOSITORY
  R241 KIO

BRANCH
  more-liberal-recent-document-duplicate-detection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13804

AFFECTED FILES
  src/core/krecentdocument.cpp

To: ngraham, broulik, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180629/6f42a9ba/attachment.htm>


More information about the kfm-devel mailing list