D13797: Only add actual documents to Recent Documents

Nathaniel Graham noreply at phabricator.kde.org
Fri Jun 29 18:27:07 BST 2018


ngraham created this revision.
ngraham added reviewers: Dolphin, Frameworks, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  KIO's Recent Documents feature is not as useful as it could be right now because KRun and the KURl dialog unconditionally add all URLs to it, so it tends to fill up with web links, appstream:/ URLs, and the like.
  
  This patch fixes that by having them only append a URL to Recent Documents if it's actually a document.

TEST PLAN
  Compiled, deployed, and rebooted.
  
  Used KRunner to go to https://kde.org and several other websites and then navigated to `recentdocuments:/ in Dolphin. No web URLs appeared in the list of recent documents.
  
  Opened a random file in Dolphin and then went to `recentdocuments:/`; the file still showed up there, as expected.

REPOSITORY
  R241 KIO

BRANCH
  recent-documents-only-shows-actual-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13797

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/kurlrequesterdialog.cpp

To: ngraham, #dolphin, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180629/8bdc5d77/attachment.htm>


More information about the kfm-devel mailing list