D12571: Modernize Settings window

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in viewsettingstab.cpp:82
> Why the change from `KComboBox` to `QComboBox`?

Because `KComboBox` didn't display correctly within a `QFormLayout`. `QComboBox` is a drop-in replacement, so it seemed like an acceptable way to fix the issue.

I also found references in commit messages for several other KDE projects to replacing `KComboBox` with `QComboBox`, so it seemed to align with the overall code direction anyway.

> elvisangelaccio wrote in viewsettingstab.cpp:109
> How about "Expandable on click" ?

That wording would imply that the folders themselves are clickable to expand them, which isn't accurate.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180625/aeeaa6ad/attachment.htm>