D12571: Modernize Settings window

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> viewsettingstab.cpp:82
>      case IconsMode: {
> -        QLabel* widthLabel = new QLabel(i18nc("@label:listbox", "Width:"), textGroup);
> -        m_widthBox = new KComboBox(textGroup);
> -        m_widthBox->addItem(i18nc("@item:inlistbox Text width", "Small"));
> -        m_widthBox->addItem(i18nc("@item:inlistbox Text width", "Medium"));
> -        m_widthBox->addItem(i18nc("@item:inlistbox Text width", "Large"));
> -        m_widthBox->addItem(i18nc("@item:inlistbox Text width", "Huge"));
> -
> -        QLabel* maxLinesLabel = new QLabel(i18nc("@label:listbox", "Maximum lines:"), textGroup);
> -        m_maxLinesBox = new KComboBox(textGroup);
> +        m_widthBox = new QComboBox();
> +        m_widthBox->addItem(i18nc("@item:inlistbox Label width", "Small"));

Why the change from `KComboBox` to `QComboBox`?

> viewsettingstab.cpp:109
>      case DetailsMode:
> -        m_expandableFolders = new QCheckBox(i18nc("@option:check", "Expandable folders"), this);
> +        m_expandableFolders = new QCheckBox(i18nc("@option:check", "Expandable"));
> +        topLayout->addRow(i18nc("@label:checkbox", "Folders:"), m_expandableFolders);

How about "Expandable on click" ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180625/7717f567/attachment.htm>