D14179: Removes useless nullptr check in FoldersPanel

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jul 17 10:35:25 BST 2018


broulik added inline comments.

INLINE COMMENTS

> folderspanel.cpp:223
>  
>      QPointer<TreeViewContextMenu> contextMenu = new TreeViewContextMenu(this, fileItem);
>      contextMenu.data()->open();

Why is it not using a `QScopedPointer` then? Would save a manual `delete` altogether

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14179

To: hallas
Cc: broulik, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180717/66aca557/attachment.htm>


More information about the kfm-devel mailing list