D14179: Removes useless nullptr check in FoldersPanel

David Hallas noreply at phabricator.kde.org
Tue Jul 17 09:02:38 BST 2018


hallas created this revision.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
hallas requested review of this revision.

REVISION SUMMARY
  In FoldersPanel::slotItemContextMenuRequested and FoldersPanel::slotViewContextMenuRequested there is a nullptr check contextMenu.data() before deleting it. But in the line above the pointer has already been dereferenced rendering the nullptr check useless.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14179

AFFECTED FILES
  src/panels/folders/folderspanel.cpp

To: hallas
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180717/32dbca75/attachment.htm>


More information about the kfm-devel mailing list