D11897: Expose group information to Dolphin's Information panel, tooltips, etc

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Jul 4 17:32:49 BST 2018


kossebau added a comment.


  In D11897#286858 <https://phabricator.kde.org/D11897#286858>, @ngraham wrote:
  
  > After investigating, it looks like this failure may be an installation issue on the build machine. The test is failing there because the new group property is inappropriately visible, but the approved change expressly covered this case by adding it to the `baloofileinformationrc` blacklist and bumping the version, which should have had the effect of not making the property visible. I suspect `baloofileinformationrc` did not get updated on the build machine the way it did on my local machine, where the test passes.
  >
  > @bcooksley, any chance you can take a look at this?
  
  
  @ngraham, @bcooksley : de-warning, my bad. The test I linked to by some magic had started to no longer fail in https://build.kde.org/view/Applications/job/Applications%20baloo-widgets%20kf5-qt5%20SUSEQt5.9/38/ (scripty surely did not fix it, or? :)  there might be something dirty still, but we have to wait for it to return if there is), but was replaced by another test failing. I just looked at the graph and assumed it was the same test failing, given the constant number 1.
  
  That test FileMetadataItemCountTest does not fail for me locally as well with latest master of KF & Qt 5.11.1.
  
  (And the new test failing, extractortest, should hopefully be fixed soon as well, as sideeffect of the regression fix patch D13885 <https://phabricator.kde.org/D13885>)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11897

To: ngraham, #baloo, michaelh
Cc: bcooksley, kossebau, bruns, cfeck, anthonyfieroni, zzag, michaelh, broulik, #dolphin, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180704/4d8ad91d/attachment.htm>


More information about the kfm-devel mailing list