D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

Michael Heidelbach noreply at phabricator.kde.org
Mon Jan 29 14:10:46 GMT 2018


michaelh planned changes to this revision.
michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadatawidgettest.cpp:74
> (Current diff looks wrong)
> 
> This could be simplified with: `QStringLiteral("%1/test.mp3").arg(TESTS_SAMPLE_FILES_PATH)`. Same below.

> (Current diff looks wrong)

You're right, it is wrong.
Also since

  Diff 3	26119	130ab80	

the series of commits looks disrupted.

I'll sort it out when https://phabricator.kde.org/D10113 is accepted, because this branch is following it

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180129/b5b6dce0/attachment.htm>


More information about the kfm-devel mailing list