D10119: baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only

Elvis Angelaccio noreply at phabricator.kde.org
Sun Jan 28 22:00:23 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadatawidgettest.cpp:74
>      m_widget->setItems(KFileItemList() 
>          << QUrl::fromLocalFile(TESTS_SAMPLE_FILES_PATH + QDir::separator() + QStringLiteral("test.mp3"))
>          << QUrl::fromLocalFile(TESTS_SAMPLE_FILES_PATH + QDir::separator() + QStringLiteral("testtagged.mp3"))

(Current diff looks wrong)

This could be simplified with: `QStringLiteral("%1/test.mp3").arg(TESTS_SAMPLE_FILES_PATH)`. Same below.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  unittest

REVISION DETAIL
  https://phabricator.kde.org/D10119

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180128/ffcdc38f/attachment.htm>


More information about the kfm-devel mailing list