D10085: Faster drag&drop in directories with thousands of files

[Mark Gaiser]

markg added a comment.


  Ho, wait.
  
  You already have all the information you need. It's just incomplete when it arrives in DragAndDropHelper::dropUrls.
  
  Look at my patch again (https://p.sc2.nl/S1yjzuGUz), i did something there in DolphinView::slotItemDropEvent which is important.
  You did not do that so the accepted value is the default which is false. In other words, the QDropEvent isn't filled with all data you need.
  
  I also mentioned that (if you go this route, which you are now) you should follow all occurrences DragAndDropHelper::dropUrls to make sure the QDropEvent that is passed is properly filled with values. It only occurs only a few times in Dolphin so it's not a bit task ;)
  
  If you follow that you don't need a new argument in there at all.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10085

To: jtamate, #dolphin, elvisangelaccio, markg
Cc: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180203/cb99807b/attachment.htm>