D17640: [versioncontrolobserver] Do not use static plugin objects

Anthony Fieroni noreply at phabricator.kde.org
Sun Dec 30 20:04:23 GMT 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in versioncontrolobserver.cpp:270
> This looks like an unrelated change. If a parent here is necessary, please add it with another commit.
> 
> If instead this change is indeed related to this patch, please explain why in the commit message. I'm not confident about this code because there is multi-threading involved.

It prevents leak, in previous commit plugins leave to application lifetime, now not.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D17640

To: anthonyfieroni, elvisangelaccio, dfaure, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181230/858d61e6/attachment.htm>


More information about the kfm-devel mailing list