D17640: [versioncontrolobserver] Do not use static plugin objects

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> versioncontrolobserver.cpp:270
>              if (enabledPlugins.contains((*it)->name())) {
> -                KVersionControlPlugin* plugin = (*it)->createInstance<KVersionControlPlugin>();
> +                KVersionControlPlugin* plugin = (*it)->createInstance<KVersionControlPlugin>(this);
>                  if (plugin) {

This looks like an unrelated change. If a parent here is necessary, please add it with another commit.

If instead this change is indeed related to this patch, please explain why in the commit message. I'm not confident about this code because there is multi-threading involved.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D17640

To: anthonyfieroni, elvisangelaccio, dfaure, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181230/9df48284/attachment.htm>